netdev - Re: [net 3/7] igb: Fix constant media auto sense switching when no cable is connected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191031.220942.1781037796505390783.davem@davemloft.net>
Date:   Thu, 31 Oct 2019 22:09:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     manfred.rudigier@...cronenergy.com, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, aaron.f.brown@...el.com
Subject: Re: [net 3/7] igb: Fix constant media auto sense switching when no
 cable is connected

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 31 Oct 2019 15:17:15 -0700

> -	} else if (!(connsw & E1000_CONNSW_SERDESD)) {
> +	} else if ((hw->phy.media_type != e1000_media_type_copper) &&
> +	    !(connsw & E1000_CONNSW_SERDESD)) {

Please indent this last line properly, the '!' should line up with the
very first column after the opennening parenthesis of the previous
line.