lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 Nov 2019 20:33:41 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     <kvalo@...eaurora.org>, <stas.yakovlev@...il.com>,
        <simon.horman@...ronome.com>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <zhongjiang@...wei.com>
Subject: [PATCH v2 3/3] b43legacy: ASoC: ux500: Remove redundant variable "count"

local variable "count" is not used. hence it is safe to remove and
just return 0.

Signed-off-by: zhong jiang <zhongjiang@...wei.com>
---
 drivers/net/wireless/broadcom/b43legacy/debugfs.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/debugfs.c b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
index 082aab8..de766c7 100644
--- a/drivers/net/wireless/broadcom/b43legacy/debugfs.c
+++ b/drivers/net/wireless/broadcom/b43legacy/debugfs.c
@@ -65,7 +65,6 @@ struct b43legacy_dfs_file * fops_to_dfs_file(struct b43legacy_wldev *dev,
 /* wl->irq_lock is locked */
 static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
 {
-	ssize_t count = 0;
 	u64 tsf;
 
 	b43legacy_tsf_read(dev, &tsf);
@@ -73,7 +72,7 @@ static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufs
 		(unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32),
 		(unsigned int)(tsf & 0xFFFFFFFFULL));
 
-	return count;
+	return 0;
 }
 
 /* wl->irq_lock is locked */
@@ -91,7 +90,6 @@ static int tsf_write_file(struct b43legacy_wldev *dev, const char *buf, size_t c
 /* wl->irq_lock is locked */
 static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
 {
-	ssize_t count = 0;
 	int i;
 
 	for (i = 0; i < 64; i++) {
@@ -99,7 +97,7 @@ static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char *buf, size
 			b43legacy_shm_read16(dev, B43legacy_SHM_WIRELESS, i));
 	}
 
-	return count;
+	return 0;
 }
 
 /* wl->irq_lock is locked */
@@ -125,7 +123,6 @@ static ssize_t shm_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufs
 static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
 {
 	struct b43legacy_txstatus_log *log = &dev->dfsentry->txstatlog;
-	ssize_t count = 0;
 	unsigned long flags;
 	int i, idx;
 	struct b43legacy_txstatus *stat;
@@ -166,7 +163,7 @@ static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, size_t b
 out_unlock:
 	spin_unlock_irqrestore(&log->lock, flags);
 
-	return count;
+	return 0;
 }
 
 /* wl->irq_lock is locked */
-- 
1.7.12.4

Powered by blists - more mailing lists