netdev - Re: [PATCH bpf-next v5 0/3] xsk: XSKMAP performance improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 2 Nov 2019 01:03:21 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Björn Töpel <bjorn.topel@...il.com>,
        netdev@...r.kernel.org, ast@...nel.org,
        jakub.kicinski@...ronome.com
Cc:     bpf@...r.kernel.org, magnus.karlsson@...il.com,
        magnus.karlsson@...el.com, maciej.fijalkowski@...el.com,
        jonathan.lemon@...il.com, toke@...hat.com
Subject: Re: [PATCH bpf-next v5 0/3] xsk: XSKMAP performance improvements

On 11/1/19 12:03 PM, Björn Töpel wrote:
> This set consists of three patches from Maciej and myself which are
> optimizing the XSKMAP lookups.  In the first patch, the sockets are
> moved to be stored at the tail of the struct xsk_map. The second
> patch, Maciej implements map_gen_lookup() for XSKMAP. The third patch,
> introduced in this revision, moves various XSKMAP functions, to permit
> the compiler to do more aggressive inlining.
> 
> Based on the XDP program from tools/lib/bpf/xsk.c where
> bpf_map_lookup_elem() is explicitly called, this work yields a 5%
> improvement for xdpsock's rxdrop scenario. The last patch yields 2%
> improvement.
> 
> Jonathan's Acked-by: for patch 1 and 2 was carried on. Note that the
> overflow checks are done in the bpf_map_area_alloc() and
> bpf_map_charge_init() functions, which was fixed in commit
> ff1c08e1f74b ("bpf: Change size to u64 for bpf_map_{area_alloc,
> charge_init}()").
> 
> Cheers,
> Björn and Maciej
> 
> [1] https://patchwork.ozlabs.org/patch/1186170/
> 
> v1->v2: * Change size/cost to size_t and use {struct, array}_size
>            where appropriate. (Jakub)
> v2->v3: * Proper commit message for patch 2.
> v3->v4: * Change size_t to u64 to handle 32-bit overflows. (Jakub)
>          * Introduced patch 3.
> v4->v5: * Use BPF_SIZEOF size, instead of BPF_DW, for correct
>            pointer-sized loads. (Daniel)
> 
> Björn Töpel (2):
>    xsk: store struct xdp_sock as a flexible array member of the XSKMAP
>    xsk: restructure/inline XSKMAP lookup/redirect/flush
> 
> Maciej Fijalkowski (1):
>    bpf: implement map_gen_lookup() callback for XSKMAP
> 
>   include/linux/bpf.h    |  25 ---------
>   include/net/xdp_sock.h |  51 ++++++++++++++-----
>   kernel/bpf/xskmap.c    | 112 +++++++++++++----------------------------
>   net/xdp/xsk.c          |  33 +++++++++++-
>   4 files changed, 106 insertions(+), 115 deletions(-)
> 

Looks good, applied, thanks!