netdev - Re: [PATCH] vsock: Simplify '__vsock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 2 Nov 2019 18:11:50 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        "David S. Miller" <davem@...emloft.net>, sunilmut@...rosoft.com,
        Willem de Bruijn <willemb@...gle.com>,
        Stefan Hajnoczi <stefanha@...hat.com>, ytht.net@...il.com,
        Arnd Bergmann <arnd@...db.de>, tglx@...utronix.de,
        Dexuan Cui <decui@...rosoft.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] vsock: Simplify '__vsock_release()'

On Thu, Oct 31, 2019 at 10:49 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> Le 31/10/2019 à 10:36, Sergei Shtylyov a écrit :
> > Hello!
> >
> > On 31.10.2019 9:47, Christophe JAILLET wrote:
> >
> >> Use '__skb_queue_purge()' instead of re-implementing it.
> >
> >    In don't see that double underscore below...
> This is a typo in the commit message.
>
> There is no need for __ because skb_dequeue was used.
>
> Could you fix it directly in the commit message (preferred solution for
> me) or should I send a V2?
>

I think is better if you send a v2 fixing this and including the R-b tags.
My R-b stays with that fixed :-)

Thanks,
Stefano