netdev - [PATCH v1] mlx4_core: fix wrong comment about the reason of subtract one from the max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191103091135.1891-1-yuval.shaia@oracle.com>
Date:   Sun,  3 Nov 2019 11:11:35 +0200
From:   Yuval Shaia <yuval.shaia@...cle.com>
To:     tariqt@...lanox.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, dotanb@....mellanox.co.il,
        eli@...lanox.co.il, vlad@...lanox.com
Cc:     Yuval Shaia <yuval.shaia@...cle.com>
Subject: [PATCH v1] mlx4_core: fix wrong comment about the reason of subtract one from the max_cqes

From: Dotan Barak <dotanb@....mellanox.co.il>

The reason for the pre-allocation of one CQE is to enable resizing of
the CQ.
Fix comment accordingly.

Signed-off-by: Dotan Barak <dotanb@....mellanox.co.il>
Signed-off-by: Eli Cohen <eli@...lanox.co.il>
Signed-off-by: Vladimir Sokolovsky <vlad@...lanox.com>
Signed-off-by: Yuval Shaia <yuval.shaia@...cle.com>
---
v0 -> v1:
	* Add . at EOL
	* Add commit message
---
 drivers/net/ethernet/mellanox/mlx4/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index fce9b3a24347..69bb6bb06e76 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -514,8 +514,7 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap)
 	dev->caps.max_rq_desc_sz     = dev_cap->max_rq_desc_sz;
 	/*
 	 * Subtract 1 from the limit because we need to allocate a
-	 * spare CQE so the HCA HW can tell the difference between an
-	 * empty CQ and a full CQ.
+	 * spare CQE to enable resizing the CQ.
 	 */
 	dev->caps.max_cqes	     = dev_cap->max_cq_sz - 1;
 	dev->caps.reserved_cqs	     = dev_cap->reserved_cqs;
-- 
2.20.1