netdev - Re: [PATCH RFC V2 5/6] net: bcmgenet: Add RGMII_RXID and RGMII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa43630e-1816-3023-5b6a-11c71fe4a258@gmx.net>
Date:   Sun, 3 Nov 2019 10:34:09 +0100
From:   Stefan Wahren <wahrenst@....net>
To:     Florian Fainelli <f.fainelli@...il.com>,
        Matthias Brugger <matthias.bgg@...nel.org>,
        Matthias Brugger <mbrugger@...e.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     Doug Berger <opendmb@...il.com>, netdev@...r.kernel.org,
        Eric Anholt <eric@...olt.net>,
        bcm-kernel-feedback-list@...adcom.com,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH RFC V2 5/6] net: bcmgenet: Add RGMII_RXID and RGMII_ID
 support

Am 02.11.19 um 21:00 schrieb Florian Fainelli:
>
> On 11/2/2019 6:41 AM, Stefan Wahren wrote:
>> This adds the missing support for the PHY modes RGMII_RXID and
>> RGMII_ID. This is necessary for the Raspberry Pi 4.
> Are both used?
Sorry, the wording was a little bit unlucky. Only the RGMII_RXID is used.
>  Your next patch only uses "rgmii-rxid". Can you remind me
> of the GTXC and RXC skew setting the PHY you are using comes up with?

I dumped the following register values before bcm54xx_config_clock_delay
tries to change the values:
SHDWSEL_MISC: 0x71E7
SHD_CLK_CTL: 0x0100

https://github.com/raspberrypi/linux/issues/3101#issuecomment-544266615

> And this was tested with Broadcom PHY (drivers/net/phy/broadcom.c)
> driver or with the Generic PHY driver?

After applying the series i'm getting the following output:

[    5.431262] bcmgenet fd580000.ethernet: failed to get enet clock
[    5.431271] bcmgenet fd580000.ethernet: GENET 5.0 EPHY: 0x0000
[    5.431283] bcmgenet fd580000.ethernet: failed to get enet-wol clock
[    5.431294] bcmgenet fd580000.ethernet: failed to get enet-eee clock
[    5.880660] libphy: bcmgenet MII bus: probed
[    5.970751] unimac-mdio unimac-mdio.-19: Broadcom UniMAC MDIO bus
[   11.570672] bcmgenet fd580000.ethernet: configuring instance for
external RGMII (RX delay)
[   11.583231] bcmgenet fd580000.ethernet eth0: Link is Down
[   16.811045] bcmgenet fd580000.ethernet eth0: Link is Up - 1Gbps/Full
- flow control rx/tx

So i assume it's the Broadcom PHY.

Regards
Stefan