netdev - Re: [net v2 4/4] net: sgi: ioc3-eth: fix setting NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 3 Nov 2019 21:45:24 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Thomas Bogendoerfer <tbogendoerfer@...e.de>,
        Ralf Baechle <ralf@...ux-mips.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-mips@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Christoph Hellwig <hch@....de>
Subject: Re: [net v2 4/4] net: sgi: ioc3-eth: fix setting NETIF_F_HIGHDMA

On 11/03/2019 01:34 PM, Thomas Bogendoerfer wrote:

> From: Christoph Hellwig <hch@....de>
> 
> Set NETIF_F_HIGHDMA together with the NETIF_F_IP_CSUM flag insted of

   Instead. :-)

> letting the second assignment overwrite it.  Probably doesn't matter
> in practice as none of the systems a IOC3 is usually found in has

   s/a/an/ (before IOC3).

> highmem to start with.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

   Your sign-off is also needed, even if you just post the other's
patches.

[...]

MBR, Sergei