netdev - Re: [PATCH V1 net 2/2] net: ena: fix too long default tx interrupt moderation interval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191104.111852.941272299166797826.davem@davemloft.net>
Date:   Mon, 04 Nov 2019 11:18:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     akiyano@...zon.com
Cc:     netdev@...r.kernel.org, dwmw@...zon.com, zorik@...zon.com,
        matua@...zon.com, saeedb@...zon.com, msw@...zon.com,
        aliguori@...zon.com, nafea@...zon.com, gtzalik@...zon.com,
        netanel@...zon.com, alisaidi@...zon.com, benh@...zon.com,
        ndagan@...zon.com, shayagr@...zon.com
Subject: Re: [PATCH V1 net 2/2] net: ena: fix too long default tx interrupt
 moderation interval

From: <akiyano@...zon.com>
Date: Mon, 4 Nov 2019 13:58:48 +0200

> From: Arthur Kiyanovski <akiyano@...zon.com>
> 
> Current default non-adaptive tx interrupt moderation interval is 196 us.
> This commit sets it to 0, which is much more sensible as a default value.
> It can be modified using ethtool -C.
> 
> Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>

I do not agree that turning TX interrupt moderation off completely is
a more sensible default value.

Maybe a much smaller value, but turning off the coalescing delay
completely is a bit much.