netdev - Re: [PATCH v2 net-next] net: of_get_phy_mode: Change API to solve int/unit warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191103.194409.422094551811274424.davem@davemloft.net>
Date:   Sun, 03 Nov 2019 19:44:09 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH v2 net-next] net: of_get_phy_mode: Change API to solve
 int/unit warnings

From: David Miller <davem@...emloft.net>
Date: Sun, 03 Nov 2019 19:26:01 -0800 (PST)

> Applied, thanks Andrew.

I tried to fix some of the allmodconfig build fallout but it just kept
piling up.  Can you fix this and resubmit?  Thanks.

drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c: In function ‘dpaa2_mac_get_if_mode’:
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c:49:12: error: too few arguments to function ‘of_get_phy_mode’
  if_mode = of_get_phy_mode(node);
            ^~~~~~~~~~~~~~~
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c: In function ‘sti_dwmac_parse_data’:
drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:274:16: warning: too many arguments for format [-Wformat-extra-args]
   dev_err(dev, "Can't get phy-mode\n", err);
                ^~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/platform_device.h:13,
                 from ./include/linux/stmmac.h:15,
                 from drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c:10:
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c: In function ‘sun7i_gmac_probe’:
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c:123:16: warning: too many arguments for format [-Wformat-extra-args]
   dev_err(dev, "Can't get phy-mode\n", ret);
                ^~~~~~~~~~~~~~~~~~~~~~
./include/linux/device.h:1658:22: note: in definition of macro ‘dev_fmt’
 #define dev_fmt(fmt) fmt
                      ^~~
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c:123:3: note: in expansion of macro ‘dev_err’
   dev_err(dev, "Can't get phy-mode\n", ret);
   ^~~~~~~