netdev - Re: [PATCH 1/1] net: ethernet: stmmac: fix warning when w=1 option is used during build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78d0c14a-fde0-72ca-e3bb-844b3a8ecac6@free.fr>
Date:   Mon, 4 Nov 2019 09:57:54 +0100
From:   Marc Gonzalez <marc.w.gonzalez@...e.fr>
To:     Christophe Roullier <christophe.roullier@...com>,
        netdev <netdev@...r.kernel.org>
Cc:     David Miller <davem@...emloft.net>, joabreu@...opsys.com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        peppe.cavallaro@...com, Andrew Lunn <andrew@...n.ch>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/1] net: ethernet: stmmac: fix warning when w=1 option is
 used during build

On 04/11/2019 09:34, Christophe Roullier wrote:

> This patch fix the following warning:
> 
> warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>   int val, ret;

FWIW, I believe the commit summary (i.e. the subject) should be as specific
as possible in the few characters allowed. In particular, it should mention
/what/ was changed.

Then the commit message would provide more information about /why/ it was
changed, and perhaps how it came to be discovered.

For example:

net: ethernet: stmmac: drop unused variable in stm32mp1_set_mode()

Building with W=1 (cf. scripts/Makefile.extrawarn) outputs:
warning: variable 'ret' set but not used [-Wunused-but-set-variable]

Drop the unused 'ret' variable.


>  drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
> index 4ef041bdf6a1..595af2ec89fb 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
> @@ -175,7 +175,7 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
>  {
>  	struct stm32_dwmac *dwmac = plat_dat->bsp_priv;
>  	u32 reg = dwmac->mode_reg;
> -	int val, ret;
> +	int val;
>  
>  	switch (plat_dat->interface) {
>  	case PHY_INTERFACE_MODE_MII:
> @@ -211,8 +211,8 @@ static int stm32mp1_set_mode(struct plat_stmmacenet_data *plat_dat)
>  	}
>  
>  	/* Need to update PMCCLRR (clear register) */
> -	ret = regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
> -			   dwmac->ops->syscfg_eth_mask);
> +	regmap_write(dwmac->regmap, reg + SYSCFG_PMCCLRR_OFFSET,
> +		     dwmac->ops->syscfg_eth_mask);
>  
>  	/* Update PMCSETR (set register) */
>  	return regmap_update_bits(dwmac->regmap, reg,