netdev - Re: [PATCH 2/5] rtnetlink: skip namespace change if already effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a6ff19a-36f5-ec3e-3616-5dc142635223@6wind.com>
Date:   Tue, 5 Nov 2019 16:42:31 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Jonas Bonn <jonas@...rbonn.se>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     davem@...emloft.net
Subject: Re: [PATCH 2/5] rtnetlink: skip namespace change if already effect

Le 05/11/2019 à 09:11, Jonas Bonn a écrit :
> RTM_SETLINK uses IFA_TARGET_NETNSID both as a selector for the device to
> act upon and as a selection of the namespace to move a device in the
> current namespace to.  As such, one ends up in the code path for setting
> the namespace every time one calls setlink on a device outside the
> current namespace.  This has the unfortunate side effect of setting the
> 'modified' flag on the device for every pass, resulting in Netlink
> notifications even when nothing was changed.
> 
> This patch just makes the namespace switch dependent upon the namespace
> the device currently resides in.
> 
> Signed-off-by: Jonas Bonn <jonas@...rbonn.se>
Acked-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>