netdev - RE: [EXT] Re: [PATCH] net: fec: add missed clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB3600C0D0D04B7EC2692A3365FF7E0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Tue, 5 Nov 2019 01:40:51 +0000
From:   Andy Duan <fugang.duan@....com>
To:     David Miller <davem@...emloft.net>
CC:     "hslester96@...il.com" <hslester96@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH] net: fec: add missed clk_disable_unprepare in
 remove

From: David Miller <davem@...emloft.net> Sent: Tuesday, November 5, 2019 9:32 AM
> From: Andy Duan <fugang.duan@....com>
> Date: Tue, 5 Nov 2019 01:27:10 +0000
> 
> > From: David Miller <davem@...emloft.net> Sent: Tuesday, November 5,
> 2019 3:36 AM
> >> From: Chuhong Yuan <hslester96@...il.com>
> >> Date: Mon,  4 Nov 2019 23:50:00 +0800
> >>
> >> > This driver forgets to disable and unprepare clks when remove.
> >> > Add calls to clk_disable_unprepare to fix it.
> >> >
> >> > Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> >>
> >> Applied.
> >
> > David, the patch introduces clock count mismatch issue, please drop it.
> 
> Please send me a revert, I'm backlogged at the moment.
> 
> Thanks.

I already give comment to Chuhong Yuan,  let's wait his response.
If he will send the fixes, let's wait his patch. If not, I will send the a
revert these two days.

Regards,
Andy