netdev - Re: [PATCH net V2] Documentation: TLS: Add missing counter description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191105092320.5e84845b@cakuba.netronome.com>
Date:   Tue, 5 Nov 2019 09:23:20 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH net V2] Documentation: TLS: Add missing counter
 description

On Tue,  5 Nov 2019 14:13:48 +0200, Tariq Toukan wrote:
> Add TLS TX counter description for the handshake retransmitted
> packets that triggers the resync procedure then skip it, going
> into the regular transmit flow.
> 
> Fixes: 46a3ea98074e ("net/mlx5e: kTLS, Enhance TX resync flow")
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>

Good enough :) Since record sequence number is part of the state
installed in the kernel the pre-kTLS part of the connection doesn't
need to be part of the handshake, application can install the key at
any point in time. But in practice it's going to be handshake most of
the time, so perhaps that's more intuitive to understand for people.

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>