netdev - Re: [PATCH V7 3/6] mdev: introduce device specific ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Nov 2019 11:17:28 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     kvm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org,
        intel-gvt-dev@...ts.freedesktop.org, kwankhede@...dia.com,
        mst@...hat.com, tiwei.bie@...el.com,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        cohuck@...hat.com, maxime.coquelin@...hat.com,
        cunming.liang@...el.com, zhihong.wang@...el.com,
        rob.miller@...adcom.com, xiao.w.wang@...el.com,
        haotian.wang@...ive.com, zhenyuw@...ux.intel.com,
        zhi.a.wang@...el.com, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, daniel@...ll.ch, farman@...ux.ibm.com,
        pasic@...ux.ibm.com, sebott@...ux.ibm.com, oberpar@...ux.ibm.com,
        heiko.carstens@...ibm.com, gor@...ux.ibm.com,
        borntraeger@...ibm.com, akrowiak@...ux.ibm.com,
        freude@...ux.ibm.com, lingshan.zhu@...el.com, idos@...lanox.com,
        eperezma@...hat.com, lulu@...hat.com, parav@...lanox.com,
        christophe.de.dinechin@...il.com, kevin.tian@...el.com,
        stefanha@...hat.com
Subject: Re: [PATCH V7 3/6] mdev: introduce device specific ops


On 2019/11/5 上午5:50, Alex Williamson wrote:
>>   EXPORT_SYMBOL(mdev_set_drvdata);
>>   
>> +
> Extra whitespace
>
>>   /* Specify the class for the mdev device, this must be called during
>> - * create() callback.
>> - */
>> + * create() callback explicitly or implicity through the helpers
> s/implicity/implicitly/
>
>> + * provided by each class. */
>>   void mdev_set_class(struct mdev_device *mdev, u16 id)
>>   {
>>   	WARN_ON(mdev->class_id);
>> @@ -55,6 +56,26 @@ void mdev_set_class(struct mdev_device *mdev, u16 id)
>>   }
>>   EXPORT_SYMBOL(mdev_set_class);
>>   
>> +/* Specify the mdev device to be a VFIO mdev device, and set VFIO
>> + * device ops for it. This must be called from the create() callback
>> + * for VFIO mdev device.
>> + */
> Comment style.  Thanks,


Will fix them all.

Thanks


>
> Alex
>