netdev - Re: [PATCH net-next 2/3] net_sched: extend packet counter to 64bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL8ox5P8MrMBCGssz7g2euPieTPK3Vx9Lxo93eVAoE7mg@mail.gmail.com>
Date:   Tue, 5 Nov 2019 14:53:36 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next 2/3] net_sched: extend packet counter to 64bit

On Tue, Nov 5, 2019 at 2:49 PM Jakub Kicinski
<jakub.kicinski@...ronome.com> wrote:
>
> On Mon,  4 Nov 2019 19:13:14 -0800, Eric Dumazet wrote:
> > diff --git a/include/net/gen_stats.h b/include/net/gen_stats.h
> > index 5f3889e7ec1bb8b5148e9c552dd222b7f1c077d8..1424e02cef90c0139a175933577f1b8537bce51a 100644
> > --- a/include/net/gen_stats.h
> > +++ b/include/net/gen_stats.h
> > @@ -10,8 +10,8 @@
> >  /* Note: this used to be in include/uapi/linux/gen_stats.h */
> >  struct gnet_stats_basic_packed {
> >       __u64   bytes;
> > -     __u32   packets;
> > -} __attribute__ ((packed));
> > +     __u64   packets;
> > +};
>
> nit: if there needs to be a respin for other reason perhaps worth
> s/__u/u/ as this is no longer a uAPI structure?

Yes, I had this in my mind, we have __u32 all over the places, with a
mix of u32/__u32 in some classes :/

Thanks.