netdev - Re: [PATCH net-next] bpf: re-fix skip write only files in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191104214943.6c4339d9@cakuba.netronome.com>
Date:   Mon, 4 Nov 2019 21:49:43 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, bpf@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] bpf: re-fix skip write only files in debugfs

On Mon, 4 Nov 2019 18:45:50 -0800, Jakub Kicinski wrote:
> On Mon,  4 Nov 2019 15:27:02 +0100, Daniel Borkmann wrote:
> >  [
> >    Hey Jakub, please take a look at the below merge fix ... still trying
> >    to figure out why the netdev doesn't appear on my test node when I
> >    wanted to run the test script, but seems independent of the fix.
> > 
> >    [...]
> >    [ 1901.270493] netdevsim: probe of netdevsim4 failed with error -17
> >    [...]
> > 
> >    # ./test_offload.py
> >    Test destruction of generic XDP...
> >    Traceback (most recent call last):
> >     File "./test_offload.py", line 800, in <module>
> >      simdev = NetdevSimDev()
> >     File "./test_offload.py", line 355, in __init__
> >      self.wait_for_netdevs(port_count)
> >     File "./test_offload.py", line 390, in wait_for_netdevs
> >      raise Exception("netdevices did not appear within timeout")
> >    Exception: netdevices did not appear within timeout
> >  ]  
> 
> I got this fixed, looks like the merged also added back some duplicated
> code, surreptitiously.
> 
> I'm still debugging another issue with the devlink.sh test which looks
> broken.

Looks like the resource tests didn't unwind the state and when health
tests were added they revealed the brokenness. A couple patches to
iproute2 are required to fix that, I'll send all the patches tomorrow.