netdev - RE: [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Nov 2019 17:38:06 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Daniel Walker <danielwa@...co.com>
CC:     Sathish Jarugumalli <sjarugum@...co.com>,
        "xe-linux-external@...co.com" <xe-linux-external@...co.com>,
        Daniel Walker <dwalker@...o99.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet
 port

>-----Original Message-----
>From: Daniel Walker <danielwa@...co.com>
>Sent: Wednesday, November 6, 2019 7:03 PM
>To: Claudiu Manoil <claudiu.manoil@....com>
>Cc: Sathish Jarugumalli <sjarugum@...co.com>; xe-linux-external@...co.com;
>Daniel Walker <dwalker@...o99.com>; David S. Miller
><davem@...emloft.net>; netdev@...r.kernel.org; linux-
>kernel@...r.kernel.org
>Subject: [PATCH] drivers: net: gianfar: Shortest frame drops at Ethernet port
>
>NXP has provided the patch for packet drops  at ethernet port
>Frames shorter than 60bytes are getting dropped at ethernetport
>need to add padding for the shorter range frames to be transmit
>the function "eth_skb_pad(skb" provides padding (and CRC) for
>packets under 60 bytes
>
>Signed-off-by: Sathish Jarugumalli <sjarugum@...co.com>
>Cc: xe-linux-external@...co.com
>Signed-off-by: Daniel Walker <dwalker@...o99.com>

Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>

Normally padding is done by the hardware, and it works at least on my
test cases and boards.
But cisco seems to have hit a case where h/w padding gets
unexpectedly disabled (concurrency issue writing the config register?).
This patch should go as a workaround, until root cause found.

-Claudiu