netdev - Re: [PATCH net-next] gianfar: Maximize Rx buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191106.102531.2219621861695403144.davem@davemloft.net>
Date:   Wed, 06 Nov 2019 10:25:31 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] gianfar: Maximize Rx buffer size

From: Claudiu Manoil <claudiu.manoil@....com>
Date: Tue,  5 Nov 2019 20:18:21 +0200

> Until now the size of a Rx buffer was artificially limited
> to 1536B (which happens to be the default, after reset, hardware
> value for a Rx buffer). This approach however leaves unused
> memory space for Rx packets, since the driver uses a paged
> allocation scheme that reserves half a page for each Rx skb.
> There's also the inconvenience that frames around 1536 bytes
> can get scattered if the limit is slightly exceeded. This limit
> can be exceeded even for standard MTU of 1500B traffic, for common
> cases like stacked VLANs, or DSA tags.
> To address these issues, let's just compute the buffer size
> starting from the upper limit of 2KB (half a page) and
> subtract the skb overhead and alignment restrictions.
> 
> Signed-off-by: Claudiu Manoil <claudiu.manoil@....com>

Applied, thanks.