netdev - Re: [PATCH net 3/3] net: bcmgenet: reapply manual settings to the PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Nov 2019 19:45:33 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Doug Berger <opendmb@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/3] net: bcmgenet: reapply manual settings to the PHY



On 11/5/2019 11:07 AM, Doug Berger wrote:
> The phy_init_hw() function may reset the PHY to a configuration
> that does not match manual network settings stored in the phydev
> structure. If the phy state machine is polled rather than event
> driven this can create a timing hazard where the phy state machine
> might alter the settings stored in the phydev structure from the
> value read from the BMCR.
> 
> This commit follows invocations of phy_init_hw() by the bcmgenet
> driver with invocations of the genphy_config_aneg() function to
> ensure that the BMCR is written to match the settings held in the
> phydev structure. This prevents the risk of manual settings being
> accidentally altered.
> 
> Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
> Signed-off-by: Doug Berger <opendmb@...il.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian