netdev - Re: [PATCH iproute2] devlink: require resource parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191106081226.GA2112@nanopsycho>
Date:   Wed, 6 Nov 2019 09:12:26 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     stephen@...workplumber.org, dsahern@...il.com,
        oss-drivers@...ronome.com, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...lanox.com>,
        Arkadi Sharshevsky <arkadis@...lanox.com>
Subject: Re: [PATCH iproute2] devlink: require resource parameters

Tue, Nov 05, 2019 at 10:13:36PM CET, jakub.kicinski@...ronome.com wrote:
>If devlink resource set parameters are not provided it crashes:
>$ devlink resource set netdevsim/netdevsim0
>Segmentation fault (core dumped)
>
>This is because even though DL_OPT_RESOURCE_PATH and
>DL_OPT_RESOURCE_SIZE are passed as o_required, the validation
>table doesn't contain a relevant string.
>
>Fixes: 8cd644095842 ("devlink: Add support for devlink resource abstraction")
>Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>--
>CC: Jiri Pirko <jiri@...lanox.com>
>CC: Arkadi Sharshevsky <arkadis@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>