netdev - Re: [PATCH net-next 0/5] lwtunnel: add ip and ip6 options setting and dumping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Nov 2019 18:50:15 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     network dev <netdev@...r.kernel.org>,
        Simon Horman <simon.horman@...ronome.com>,
        Jiri Benc <jbenc@...hat.com>, Thomas Graf <tgraf@...g.ch>,
        William Tu <u9012063@...il.com>
Subject: Re: [PATCH net-next 0/5] lwtunnel: add ip and ip6 options setting and dumping

On Thu, Nov 7, 2019 at 1:15 PM David Miller <davem@...emloft.net> wrote:
>
> From: Xin Long <lucien.xin@...il.com>
> Date: Wed,  6 Nov 2019 17:01:02 +0800
>
> > With this patchset, users can configure options by ip route encap
> > for geneve, vxlan and ersapn lwtunnel, like:
> >
> >   # ip r a 1.1.1.0/24 encap ip id 1 geneve class 0 type 0 \
> >     data "1212121234567890" dst 10.1.0.2 dev geneve1
> >
> >   # ip r a 1.1.1.0/24 encap ip id 1 vxlan gbp 456 \
> >     dst 10.1.0.2 dev erspan1
> >
> >   # ip r a 1.1.1.0/24 encap ip id 1 erspan ver 1 idx 123 \
> >     dst 10.1.0.2 dev erspan1
> >
> > iproute side patch is attached on the reply of this mail.
> >
> > Thank Simon for good advice.
>
> Series applied, looks good.
>
> Can you comment about how this code is using the deprecated nla
> parsers for new options?
I didn't think too much, just used what it's using in cls_flower.c and
act_tunnel_key.c to parse GENEVE options.

Now think about it again, nla_parse_nested() should always be used on
new options, should I post a fix for it? since no code to access this
from userspace yet.