netdev - Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191107085013-mutt-send-email-mst@kernel.org>
Date:   Thu, 7 Nov 2019 08:50:46 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     kvm@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org,
        intel-gvt-dev@...ts.freedesktop.org, kwankhede@...dia.com,
        alex.williamson@...hat.com, tiwei.bie@...el.com,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        cohuck@...hat.com, maxime.coquelin@...hat.com,
        cunming.liang@...el.com, zhihong.wang@...el.com,
        rob.miller@...adcom.com, xiao.w.wang@...el.com,
        haotian.wang@...ive.com, zhenyuw@...ux.intel.com,
        zhi.a.wang@...el.com, jani.nikula@...ux.intel.com,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, daniel@...ll.ch, farman@...ux.ibm.com,
        pasic@...ux.ibm.com, sebott@...ux.ibm.com, oberpar@...ux.ibm.com,
        heiko.carstens@...ibm.com, gor@...ux.ibm.com,
        borntraeger@...ibm.com, akrowiak@...ux.ibm.com,
        freude@...ux.ibm.com, lingshan.zhu@...el.com, idos@...lanox.com,
        eperezma@...hat.com, lulu@...hat.com, parav@...lanox.com,
        christophe.de.dinechin@...il.com, kevin.tian@...el.com,
        stefanha@...hat.com
Subject: Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to
 implement virtio-mdev framework

On Thu, Nov 07, 2019 at 09:32:29PM +0800, Jason Wang wrote:
> 
> On 2019/11/7 下午9:08, Michael S. Tsirkin wrote:
> > On Thu, Nov 07, 2019 at 08:43:29PM +0800, Jason Wang wrote:
> > > On 2019/11/7 下午7:21, Michael S. Tsirkin wrote:
> > > > On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote:
> > > > > On 2019/11/7 下午5:08, Michael S. Tsirkin wrote:
> > > > > > On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote:
> > > > > > > This sample driver creates mdev device that simulate virtio net device
> > > > > > > over virtio mdev transport. The device is implemented through vringh
> > > > > > > and workqueue. A device specific dma ops is to make sure HVA is used
> > > > > > > directly as the IOVA. This should be sufficient for kernel virtio
> > > > > > > driver to work.
> > > > > > > 
> > > > > > > Only 'virtio' type is supported right now. I plan to add 'vhost' type
> > > > > > > on top which requires some virtual IOMMU implemented in this sample
> > > > > > > driver.
> > > > > > > 
> > > > > > > Acked-by: Cornelia Huck<cohuck@...hat.com>
> > > > > > > Signed-off-by: Jason Wang<jasowang@...hat.com>
> > > > > > I'd prefer it that we call this something else, e.g.
> > > > > > mvnet-loopback. Just so people don't expect a fully
> > > > > > functional device somehow. Can be renamed when applying?
> > > > > Actually, I plan to extend it as another standard network interface for
> > > > > kernel. It could be either a standalone pseudo device or a stack device.
> > > > > Does this sounds good to you?
> > > > > 
> > > > > Thanks
> > > > That's a big change in an interface so it's a good reason
> > > > to rename the driver at that point right?
> > > > Oherwise users of an old kernel would expect a stacked driver
> > > > and get a loopback instead.
> > > > 
> > > > Or did I miss something?
> > > 
> > > My understanding is that it was a sample driver in /doc. It should not be
> > > used in production environment. Otherwise we need to move it to
> > > driver/virtio.
> > > 
> > > But if you insist, I can post a V11.
> > > 
> > > Thanks
> > this can be a patch on top.
> 
> 
> Then maybe it's better just extend it to work as a normal networking device
> on top?
> 
> Thanks

That would be a substantial change. Maybe drop 6/6 for now until
we have a better handle on this?