netdev - Re: [PATCH v1 1/4] mdio-bitbang: add SMI0 mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191107154201.GF7344@lunn.ch>
Date:   Thu, 7 Nov 2019 16:42:01 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Grzeschik <m.grzeschik@...gutronix.de>
Cc:     netdev@...r.kernel.org, Tristram.Ha@...rochip.com,
        UNGLinuxDriver@...rochip.com, kernel@...gutronix.de
Subject: Re: [PATCH v1 1/4] mdio-bitbang: add SMI0 mode support

On Thu, Nov 07, 2019 at 12:00:27PM +0100, Michael Grzeschik wrote:
> Some microchip phys support the Serial Management Interface Protocol
> (SMI) for the configuration of the extended register set. We add
> MII_ADDR_SMI0 as an available interface to the mdiobb write and read
> functions, as this interface can be easy realized using the bitbang mdio
> driver.
> 
> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>

Hi Michael

I don't like adding vendor proprietary stuff to generic code like
this. Please could you see if you can make use of mdiobb_ops in some
way? Move all this junk out into a mdio-kzs88x3.c?

Thanks
	Andrew