netdev - Re: [PATCH net 0/3] net/tls: add a TX lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191106.173355.264262348695178120.davem@davemloft.net>
Date:   Wed, 06 Nov 2019 17:33:55 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        borisp@...lanox.com, aviadye@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net
Subject: Re: [PATCH net 0/3] net/tls: add a TX lock

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Tue,  5 Nov 2019 14:24:33 -0800

> Some time ago Pooja and Mallesham started reporting crashes with
> an async accelerator. After trying to poke the existing logic into
> shape I came to the conclusion that it can't be trusted, and to
> preserve our sanity we should just add a lock around the TX side.
> 
> First patch removes the sk_write_pending checks from the write
> space callbacks. Those don't seem to have a logical justification.
> 
> Patch 2 adds the TX lock and patch 3 associated test (which should
> hang with current net).
> 
> Mallesham reports that even with these fixes applied the async
> accelerator workload still occasionally hangs waiting for socket
> memory. I suspect that's strictly related to the way async crypto
> is integrated in TLS, so I think we should get these into net or
> net-next and move from there.

Series applied and queued up for -stable, thanks Jakub.