netdev - Re: [PATCH net-next] net: phy: at803x: add missing dependency on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a297041-2750-eba4-c172-c63c605103ee@gmail.com>
Date:   Thu, 7 Nov 2019 10:15:04 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     madalin.bucur@....com, davem@...emloft.net, netdev@...r.kernel.org
Cc:     hkallweit1@...il.com, andrew@...n.ch
Subject: Re: [PATCH net-next] net: phy: at803x: add missing dependency on
 CONFIG_REGULATOR

On 11/7/19 5:03 AM, Madalin Bucur wrote:
> Compilation fails on PPC targets as CONFIG_REGULATOR is not set and
> drivers/regulator/devres.c is not compiled in while functions exported
> there are used by drivers/net/phy/at803x.c. Here's the error log:
> 
>   LD      .tmp_vmlinux1
> drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_set_voltage_sel':
> drivers/net/phy/at803x.c:294: undefined reference to `.rdev_get_drvdata'
> drivers/net/phy/at803x.o: In function `at803x_rgmii_reg_get_voltage_sel':
> drivers/net/phy/at803x.c:306: undefined reference to `.rdev_get_drvdata'
> drivers/net/phy/at803x.o: In function `at8031_register_regulators':
> drivers/net/phy/at803x.c:359: undefined reference to `.devm_regulator_register'
> drivers/net/phy/at803x.c:365: undefined reference to `.devm_regulator_register'
> drivers/net/phy/at803x.o:(.data.rel+0x0): undefined reference to `regulator_list_voltage_table'
> linux/Makefile:1074: recipe for target 'vmlinux' failed
> make[1]: *** [vmlinux] Error 1
> 
> Fixes: 2f664823a470 ("net: phy: at803x: add device tree binding")
> Signed-off-by: Madalin Bucur <madalin.bucur@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Humm, I was actually wondering if we were guaranteed to have stubs
provided, that seems to answer my question.
-- 
Florian