netdev - Re: [PATCH net] net/smc: fix ethernet interface refcounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191106.174601.340921510977427928.davem@davemloft.net>
Date:   Wed, 06 Nov 2019 17:46:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kgraul@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        heiko.carstens@...ibm.com, raspl@...ux.ibm.com,
        ubraun@...ux.ibm.com
Subject: Re: [PATCH net] net/smc: fix ethernet interface refcounting

From: Karsten Graul <kgraul@...ux.ibm.com>
Date: Wed,  6 Nov 2019 10:49:57 +0100

> From: Ursula Braun <ubraun@...ux.ibm.com>
> 
> If a pnet table entry is to be added mentioning a valid ethernet
> interface, but an invalid infiniband or ISM device, the dev_put()
> operation for the ethernet interface is called twice, resulting
> in a negative refcount for the ethernet interface, which disables
> removal of such a network interface.
> 
> This patch removes one of the dev_put() calls.
> 
> Fixes: 890a2cb4a966 ("net/smc: rework pnet table")
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>
> Signed-off-by: Karsten Graul <kgraul@...ux.ibm.com>

Applied and queued up for -stable, thanks.