netdev - Re: [PATCH V11 2/6] modpost: add support for mdev class id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Nov 2019 01:06:40 +0530
From:   Kirti Wankhede <kwankhede@...dia.com>
To:     Jason Wang <jasowang@...hat.com>, <kvm@...r.kernel.org>,
        <linux-s390@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        <intel-gfx@...ts.freedesktop.org>,
        <intel-gvt-dev@...ts.freedesktop.org>,
        <alex.williamson@...hat.com>, <mst@...hat.com>,
        <tiwei.bie@...el.com>
CC:     <virtualization@...ts.linux-foundation.org>,
        <netdev@...r.kernel.org>, <cohuck@...hat.com>,
        <maxime.coquelin@...hat.com>, <cunming.liang@...el.com>,
        <zhihong.wang@...el.com>, <rob.miller@...adcom.com>,
        <xiao.w.wang@...el.com>, <haotian.wang@...ive.com>,
        <zhenyuw@...ux.intel.com>, <zhi.a.wang@...el.com>,
        <jani.nikula@...ux.intel.com>, <joonas.lahtinen@...ux.intel.com>,
        <rodrigo.vivi@...el.com>, <airlied@...ux.ie>, <daniel@...ll.ch>,
        <farman@...ux.ibm.com>, <pasic@...ux.ibm.com>,
        <sebott@...ux.ibm.com>, <oberpar@...ux.ibm.com>,
        <heiko.carstens@...ibm.com>, <gor@...ux.ibm.com>,
        <borntraeger@...ibm.com>, <akrowiak@...ux.ibm.com>,
        <freude@...ux.ibm.com>, <lingshan.zhu@...el.com>,
        <eperezma@...hat.com>, <lulu@...hat.com>, <parav@...lanox.com>,
        <christophe.de.dinechin@...il.com>, <kevin.tian@...el.com>,
        <stefanha@...hat.com>, <rdunlap@...radead.org>
Subject: Re: [PATCH V11 2/6] modpost: add support for mdev class id



On 11/7/2019 8:41 PM, Jason Wang wrote:
> Add support to parse mdev class id table.
> 
> Reviewed-by: Parav Pandit <parav@...lanox.com>
> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Reviewed-by: Kirti Wankhede <kwankhede@...dia.com>

Thanks,
Kirti

> ---
>   drivers/vfio/mdev/vfio_mdev.c     |  2 ++
>   scripts/mod/devicetable-offsets.c |  3 +++
>   scripts/mod/file2alias.c          | 11 +++++++++++
>   3 files changed, 16 insertions(+)
> 
> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c
> index 38431e9ef7f5..a6641cd8b5a3 100644
> --- a/drivers/vfio/mdev/vfio_mdev.c
> +++ b/drivers/vfio/mdev/vfio_mdev.c
> @@ -125,6 +125,8 @@ static const struct mdev_class_id vfio_id_table[] = {
>   	{ 0 },
>   };
>   
> +MODULE_DEVICE_TABLE(mdev, vfio_id_table);
> +
>   static struct mdev_driver vfio_mdev_driver = {
>   	.name	= "vfio_mdev",
>   	.probe	= vfio_mdev_probe,
> diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable-offsets.c
> index 054405b90ba4..6cbb1062488a 100644
> --- a/scripts/mod/devicetable-offsets.c
> +++ b/scripts/mod/devicetable-offsets.c
> @@ -231,5 +231,8 @@ int main(void)
>   	DEVID(wmi_device_id);
>   	DEVID_FIELD(wmi_device_id, guid_string);
>   
> +	DEVID(mdev_class_id);
> +	DEVID_FIELD(mdev_class_id, id);
> +
>   	return 0;
>   }
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index c91eba751804..45f1c22f49be 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -1335,6 +1335,16 @@ static int do_wmi_entry(const char *filename, void *symval, char *alias)
>   	return 1;
>   }
>   
> +/* looks like: "mdev:cN" */
> +static int do_mdev_entry(const char *filename, void *symval, char *alias)
> +{
> +	DEF_FIELD(symval, mdev_class_id, id);
> +
> +	sprintf(alias, "mdev:c%02X", id);
> +	add_wildcard(alias);
> +	return 1;
> +}
> +
>   /* Does namelen bytes of name exactly match the symbol? */
>   static bool sym_is(const char *name, unsigned namelen, const char *symbol)
>   {
> @@ -1407,6 +1417,7 @@ static const struct devtable devtable[] = {
>   	{"typec", SIZE_typec_device_id, do_typec_entry},
>   	{"tee", SIZE_tee_client_device_id, do_tee_entry},
>   	{"wmi", SIZE_wmi_device_id, do_wmi_entry},
> +	{"mdev", SIZE_mdev_class_id, do_mdev_entry},
>   };
>   
>   /* Create MODULE_ALIAS() statements.
>