netdev - Re: [PATCH v2 bpf-next 04/17] libbpf: Add support to attach to fentry/fexit tracing progs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <693CECA2-5588-43AD-9AC9-CF5AF30C4589@fb.com>
Date:   Thu, 7 Nov 2019 22:51:41 +0000
From:   Song Liu <songliubraving@...com>
To:     Alexei Starovoitov <ast@...nel.org>
CC:     David Miller <davem@...emloft.net>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "x86@...nel.org" <x86@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next 04/17] libbpf: Add support to attach to
 fentry/fexit tracing progs



> On Nov 6, 2019, at 9:46 PM, Alexei Starovoitov <ast@...nel.org> wrote:
> 
> Teach libbpf to recognize tracing programs types and attach them to
> fentry/fexit.
> 
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Acked-by: Song Liu <songliubraving@...com>

With nit below:

> ---
> tools/include/uapi/linux/bpf.h |  2 ++
> tools/lib/bpf/libbpf.c         | 61 +++++++++++++++++++++++++++++-----
> tools/lib/bpf/libbpf.h         |  5 +++
> tools/lib/bpf/libbpf.map       |  2 ++
> 4 files changed, 61 insertions(+), 9 deletions(-)
> 

[...]

> 
> /* Accessors of bpf_program */
> struct bpf_program;
> @@ -248,6 +251,8 @@ LIBBPF_API struct bpf_link *
> bpf_program__attach_raw_tracepoint(struct bpf_program *prog,
> 				   const char *tp_name);
> 
> +LIBBPF_API struct bpf_link *
> +bpf_program__attach_trace(struct bpf_program *prog);
> struct bpf_insn;

attach_trace is not very clear. I guess we cannot call it 
attach_ftrace? Maybe we call it attach_fentry and attach_fexit
(two names pointing to same function)?