netdev - Re: [Possible regression?] ip route deletion behavior change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2db4c4569c61cafb1abb609609740e83d242b5f1.camel@alliedtelesis.co.nz>
Date:   Thu, 7 Nov 2019 03:00:45 +0000
From:   Mark Tomlinson <Mark.Tomlinson@...iedtelesis.co.nz>
To:     "hd@...cillation.de" <hd@...cillation.de>,
        "dsahern@...il.com" <dsahern@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [Possible regression?] ip route deletion behavior change

On Wed, 2019-11-06 at 16:56 +0100, Hendrik Donner wrote:
> On 10/31/19 9:41 PM, David Ahern wrote:
> > 
> > devices not associated with a VRF table are implicitly tied to the
> > default == main table.
> > 
> > Can you test this change:
> > 
> > diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
> > index 0913a090b2bf..f1888c683426 100644
> > --- a/net/ipv4/fib_semantics.c
> > +++ b/net/ipv4/fib_semantics.c
> > @@ -1814,8 +1814,8 @@ int fib_sync_down_addr(struct net_device *dev,
> > __be32 local)
> >         int ret = 0;
> >         unsigned int hash = fib_laddr_hashfn(local);
> >         struct hlist_head *head = &fib_info_laddrhash[hash];
> > +       int tb_id = l3mdev_fib_table(dev) ? : RT_TABLE_MAIN;
> >         struct net *net = dev_net(dev);
> > -       int tb_id = l3mdev_fib_table(dev);
> >         struct fib_info *fi;
> > 
> >         if (!fib_info_laddrhash || local == 0)
> > 
> > [ As DaveM noted, you should cc maintainers and author(s) of suspected
> > regression patches ]
> > 
> 
> I've tested your patch and it restores the expected behavior.
> 
> + Mark Tomlinson so he can have a look at it too.

I admit that I did not cater for the case where l3mdev_fib_table(dev)
returned NULL. I am OK with this change.