netdev - Re: [PATCH net-next] tcp: fix data-race in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 06 Nov 2019 21:38:51 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, soheil@...gle.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net-next] tcp: fix data-race in tcp_recvmsg()

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed,  6 Nov 2019 12:59:33 -0800

> Reading tp->recvmsg_inq after socket lock is released
> raises a KCSAN warning [1]
> 
> Replace has_tss & has_cmsg by cmsg_flags and make
> sure to not read tp->recvmsg_inq a second time.
> 
> [1]
> BUG: KCSAN: data-race in tcp_chrono_stop / tcp_recvmsg
 ...
> Fixes: b75eba76d3d7 ("tcp: send in-queue bytes in cmsg upon read")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied, thanks Eric.