netdev - Re: [PATCH v3 bpf-next 13/18] bpf: Fix race in btf_resolve_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F06B5253-8763-4D97-A4A4-54ACE4E14C52@fb.com>
Date:   Fri, 8 Nov 2019 07:32:58 +0000
From:   Song Liu <songliubraving@...com>
To:     Alexei Starovoitov <ast@...nel.org>
CC:     David Miller <davem@...emloft.net>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "x86@...nel.org" <x86@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 13/18] bpf: Fix race in
 btf_resolve_helper_id()



> On Nov 7, 2019, at 10:40 PM, Alexei Starovoitov <ast@...nel.org> wrote:
> 
> btf_resolve_helper_id() caching logic is a bit racy, since under root the
> verifier can verify several programs in parallel. Fix it with READ/WRITE_ONCE.
> Fix the type as well, since error is also recorded.
> 
> Fixes: a7658e1a4164 ("bpf: Check types of arguments passed into helpers")
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>

Acked-by: Song Liu <songliubraving@...com>