netdev - Re: [PATCH] tcp: remove redundant new line from tcp_event_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <795f4bb1-b40e-1745-0df4-6e55d80d5272@gmail.com>
Date:   Fri, 8 Nov 2019 04:22:19 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Tony Lu <tonylu@...ux.alibaba.com>, edumazet@...gle.com,
        rostedt@...dmis.org, mingo@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yafang Shao <laoar.shao@...il.com>
Subject: Re: [PATCH] tcp: remove redundant new line from tcp_event_sk_skb



On 11/8/19 1:50 AM, Tony Lu wrote:
> This removes '\n' from trace event class tcp_event_sk_skb to avoid
> redundant new blank line and make output compact.
> 
> Signed-off-by: Tony Lu <tonylu@...ux.alibaba.com>
> ---
>  include/trace/events/tcp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
> index 2bc9960a31aa..cf97f6339acb 100644
> --- a/include/trace/events/tcp.h
> +++ b/include/trace/events/tcp.h
> @@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
>  			      sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
>  	),
>  
> -	TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
> +	TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
>  		  __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
>  		  __entry->saddr_v6, __entry->daddr_v6,
>  		  show_tcp_state_name(__entry->state))
> 

This seems good to me. Only few comments :

I would add a

Fixes: af4325ecc24f ("tcp: expose sk_state in tcp_retransmit_skb tracepoint")

And also CC (I just did in this reply) the author of the above patch to make sure nothing unexpected happens.

Thanks.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>