netdev - RE: [PATCH net-next v2 04/10] devlink: Support subdev HW address get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR05MB48663DAB2C9B5359DB15BB89D17B0@AM0PR05MB4866.eurprd05.prod.outlook.com>
Date:   Fri, 8 Nov 2019 18:00:26 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Yuval Avnery <yuvalav@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        Daniel Jurgens <danielj@...lanox.com>,
        "andrew.gospodarek@...adcom.com" <andrew.gospodarek@...adcom.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>,
        Yuval Avnery <yuvalav@...lanox.com>
Subject: RE: [PATCH net-next v2 04/10] devlink: Support subdev HW address get



> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of Yuval Avnery
> Sent: Friday, November 8, 2019 10:19 AM
> To: netdev@...r.kernel.org
> Cc: Jiri Pirko <jiri@...lanox.com>; Saeed Mahameed
> <saeedm@...lanox.com>; leon@...nel.org; davem@...emloft.net;
> jakub.kicinski@...ronome.com; shuah@...nel.org; Daniel Jurgens
> <danielj@...lanox.com>; Parav Pandit <parav@...lanox.com>;
> andrew.gospodarek@...adcom.com; michael.chan@...adcom.com; Yuval
> Avnery <yuvalav@...lanox.com>
> Subject: [PATCH net-next v2 04/10] devlink: Support subdev HW address get
> 
> Allow privileged user to get the HW address of a subdev.
> 
> Example:
> 
> $ devlink subdev show pci/0000:03:00.0/1
> pci/0000:03:00.0/1: flavour pcivf pf 0 vf 0 port_index 1 hw_addr
> 00:23:35:af:35:34
> 
> $ devlink subdev show pci/0000:03:00.0/1 -pj {
>     "subdev": {
>         "pci/0000:03:00.0/1": {
>             "flavour": "pcivf",
>             "pf": 0,
>             "vf": 0,
>             "port_index": 1,
>             "hw_addr": "00:23:35:af:35:34"
I prefer this to be 'address' to match to 'ip link set address LLADDR'.
That will make it consistent with rest of the iproute2/ip tool.
So that users don't have to remember one mor keyword for the 'address'.