netdev - Re: [PATCH net-next 09/19] vfio/mdev: Expose mdev alias in sysfs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191108110355.77128e6f@x1.home>
Date:   Fri, 8 Nov 2019 11:03:55 -0700
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Parav Pandit <parav@...lanox.com>, davem@...emloft.net,
        kvm@...r.kernel.org, netdev@...r.kernel.org, saeedm@...lanox.com,
        kwankhede@...dia.com, leon@...nel.org, cohuck@...hat.com,
        jiri@...lanox.com, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next 09/19] vfio/mdev: Expose mdev alias in sysfs
 tree

On Fri, 8 Nov 2019 14:22:30 +0100
Jiri Pirko <jiri@...nulli.us> wrote:

> Thu, Nov 07, 2019 at 05:08:24PM CET, parav@...lanox.com wrote:
> 
> [...]
> 
> > 
> >+static ssize_t alias_show(struct device *device,
> >+			  struct device_attribute *attr, char *buf)
> >+{
> >+	struct mdev_device *dev = mdev_from_dev(device);
> >+
> >+	if (!dev->alias)
> >+		return -EOPNOTSUPP;
> >+
> >+	return sprintf(buf, "%s\n", dev->alias);
> >+}
> >+static DEVICE_ATTR_RO(alias);  
> 
> I wonder, rather than adding another sysfs file, why the alias can't be
> simply a symlink to the aliased mdev directory?

The user doesn't know the alias in advance, it seems problematic to
assume an arbitrarily named link is the alias.  Thanks,

Alex

> >+
> > static const struct attribute *mdev_device_attrs[] = {
> >+	&dev_attr_alias.attr,
> > 	&dev_attr_remove.attr,
> > 	NULL,
> > };
> >-- 
> >2.19.2
> >