netdev - Possibility of me mainlining Tehuti Networks 10GbE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <PS2P216MB0755843A57F285E4EE452EE5807B0@PS2P216MB0755.KORP216.PROD.OUTLOOK.COM>
Date:   Fri, 8 Nov 2019 02:24:44 +0000
From:   Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Andy Gospodarek <andy@...yhouse.net>,
        "David S. Miller" <davem@...emloft.net>
Subject: Possibility of me mainlining Tehuti Networks 10GbE driver

Hi all,

To start off, if I am emailing the wrong people, please blame the output 
of: "scripts/get_maintainer.pl drivers/net/ethernet/tehuti/" and let me 
know who I should be contacting. Should I add in 
"linux-kernel@...r.kernel.org"?

I just discovered that the Tehuti 10GbE networking drivers (required for 
things such as some AKiTiO Thunderbolt to 10GbE adapters) are not in 
mainline. I am interested in mainlining it, but need to know how much 
work it would take and if it will force me to be the maintainer for all 
eternity.

The driver, in tn40xx-0.3.6.15-c.tar appears to be available here:
Link: https://www.akitio.com/faq/341-thunder3-10gbe-adapter-can-i-use-this-network-adapter-on-linux
Also here:
Link: https://github.com/acooks/tn40xx-driver

I see some immediate style problems and indentation issues. I can fix 
these.

The current driver only works with Linux v4.19, I believe. There are a 
small handful of compile errors with v5.4. I can probably fix these.

However, could somebody please comment on any technical issues that you 
can see here? How much work do you think I would have to do to mainline 
this? Would I have to buy such a device for testing? Would I have to buy 
*all* of the supported devices for testing? Or can other people do that 
for me?

I am not keen on having to buy anything without mainline support - it is 
an instant disqualification of a hardware vendor. It results in a 
terrible user experience for experienced people (might not be able to 
use latest kernel which is needed for supporting other things) and is 
debilitating for people new to Linux who do not how to use the terminal, 
possibly enough so that they will go back to Windows.

Andy, what is your relationship to Tehuti Networks? Would you be happy 
to maintain this if I mainlined it? It says you are maintainer of 
drivers/net/ethernet/tehuti/ directory. I will not do this if I am 
expected to maintain it - in no small part because I do not know a lot 
about it. I will only be modifying what is currently available to make 
it acceptable for mainline, if possible.

Also, license issues - does GPLv2 permit mainlining to happen? I believe 
the Tehuti driver is available under GPLv2 (correct me if I am wrong).

Would I need to send patches for this, or for something this size, is it 
better to send a pull request? If I am going to do patches, I will need 
to make a gmail account or something, as Outlook messes with the 
encoding of the things which I send.

Thanks for any comments on this.

Kind regards,
Nicholas Johnson