netdev - Re: [PATCH bpf-next 4/6] libbpf: Use pr_warn() when printing netlink errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6E83C846-60D7-4289-B696-6982FC6CE26D@fb.com>
Date:   Fri, 8 Nov 2019 19:37:09 +0000
From:   Song Liu <songliubraving@...com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
CC:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>, Martin Lau <kafai@...com>,
        Yonghong Song <yhs@...com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next 4/6] libbpf: Use pr_warn() when printing netlink
 errors



> On Nov 7, 2019, at 8:52 AM, Toke Høiland-Jørgensen <toke@...hat.com> wrote:
> 
> From: Toke Høiland-Jørgensen <toke@...hat.com>
> 
> The netlink functions were using fprintf(stderr, ) directly to print out
> error messages, instead of going through the usual logging macros. This
> makes it impossible for the calling application to silence or redirect
> those error messages. Fix this by switching to pr_warn() in nlattr.c and
> netlink.c.
> 
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
> 

Acked-by: Song Liu <songliubraving@...com>