netdev - Re: [PATCH v3 bpf-next 13/18] bpf: Fix race in btf_resolve_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzbTvKqLDhB6ncZWKt=uL-XDT1GGapzhOJE2a-fWsdGa3A@mail.gmail.com>
Date:   Fri, 8 Nov 2019 11:58:09 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <ast@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>, x86@...nel.org,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 13/18] bpf: Fix race in btf_resolve_helper_id()

On Thu, Nov 7, 2019 at 10:42 PM Alexei Starovoitov <ast@...nel.org> wrote:
>
> btf_resolve_helper_id() caching logic is a bit racy, since under root the
> verifier can verify several programs in parallel. Fix it with READ/WRITE_ONCE.
> Fix the type as well, since error is also recorded.
>
> Fixes: a7658e1a4164 ("bpf: Check types of arguments passed into helpers")
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> ---

looks good

Acked-by: Andrii Nakryiko <andriin@...com>

>  include/linux/bpf.h   |  5 +++--
>  kernel/bpf/btf.c      | 26 +++++++++++++++++++++++++-
>  kernel/bpf/verifier.c |  8 +++-----
>  net/core/filter.c     |  2 +-
>  4 files changed, 32 insertions(+), 9 deletions(-)
>

[...]