netdev - Re: [PATCH net-next] net: icmp: fix data-race in cmp_global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 08 Nov 2019 12:34:43 -0800 (PST)
From:   David Miller <davem@...hat.com>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net-next] net: icmp: fix data-race in cmp_global_allow()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri,  8 Nov 2019 10:34:47 -0800

> This code reads two global variables without protection
> of a lock. We need READ_ONCE()/WRITE_ONCE() pairs to
> avoid load/store-tearing and better document the intent.
> 
> KCSAN reported :
> BUG: KCSAN: data-race in icmp_global_allow / icmp_global_allow
 ...
> Fixes: 4cdf507d5452 ("icmp: add a global rate limitation")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied, thanks Eric.