netdev - Re: [PATCH 0/2] unix: Show number of scm files in fdinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eb70753a-5bd7-2c94-a381-71e02ba112f6@kernel.dk>
Date:   Fri, 8 Nov 2019 16:15:05 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     David Miller <davem@...emloft.net>, ktkhai@...tuozzo.com
Cc:     pankaj.laxminarayan.bharadiya@...el.com, keescook@...omium.org,
        viro@...iv.linux.org.uk, hare@...e.com, tglx@...utronix.de,
        edumazet@...gle.com, arnd@...db.de, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] unix: Show number of scm files in fdinfo

On 11/8/19 12:30 PM, David Miller wrote:
> From: Kirill Tkhai <ktkhai@...tuozzo.com>
> Date: Thu, 07 Nov 2019 15:14:15 +0300
> 
>> Unix sockets like a block box. You never know what is pending there:
>> there may be a file descriptor holding a mount or a block device,
>> or there may be whole universes with namespaces, sockets with receive
>> queues full of sockets etc.
>>
>> The patchset makes number of pending scm files be visible in fdinfo.
>> This may be useful to determine, that socket should be investigated
>> or which task should be killed to put reference counter on a resourse.
> 
> This doesn't even compile:
> 
> net/unix/af_unix.c: In function ‘scm_stat_add’:
> ./include/linux/lockdep.h:365:52: error: invalid type argument of ‘->’ (have ‘spinlock_t’ {aka ‘struct spinlock’})
>   #define lockdep_is_held(lock)  lock_is_held(&(lock)->dep_map)

Quick guess is a missing & on those locks...

But in any case, the feature looks really useful, also for io_uring which
puts all its registered files in the skb. I'll give it a tester here.

-- 
Jens Axboe