netdev - Re: [PATCH v3 bpf-next 14/18] bpf: Compare BTF types of functions arguments with actual types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYLSaXLwp3Ujk07TcjQSvOo1RKcGE6fT7jh_tOpREne2w@mail.gmail.com>
Date:   Fri, 8 Nov 2019 15:46:54 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <ast@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>, x86@...nel.org,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 14/18] bpf: Compare BTF types of functions
 arguments with actual types

On Thu, Nov 7, 2019 at 10:42 PM Alexei Starovoitov <ast@...nel.org> wrote:
>
> Make the verifier check that BTF types of function arguments match actual types
> passed into top-level BPF program and into BPF-to-BPF calls. If types match
> such BPF programs and sub-programs will have full support of BPF trampoline. If
> types mismatch the trampoline has to be conservative. It has to save/restore
> all 5 program arguments and assume 64-bit scalars. If FENTRY/FEXIT program is
> attached to this program in the future such FENTRY/FEXIT program will be able
> to follow pointers only via bpf_probe_read_kernel().
>
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> ---

Acked-by: Andrii Nakryiko <andriin@...com>

>  include/linux/bpf.h          |   8 +++
>  include/linux/bpf_verifier.h |   1 +
>  kernel/bpf/btf.c             | 117 +++++++++++++++++++++++++++++++++++
>  kernel/bpf/syscall.c         |   1 +
>  kernel/bpf/verifier.c        |  18 +++++-
>  5 files changed, 142 insertions(+), 3 deletions(-)
>

[...]