netdev - Re: [PATCH net-next] net: add annotations on hh->hh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191107.200749.349173827390952058.davem@davemloft.net>
Date:   Thu, 07 Nov 2019 20:07:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net-next] net: add annotations on hh->hh_len lockless
 accesses

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu,  7 Nov 2019 18:29:11 -0800

> KCSAN reported a data-race [1]
> 
> While we can use READ_ONCE() on the read sides,
> we need to make sure hh->hh_len is written last.
> 
> [1]
> 
> BUG: KCSAN: data-race in eth_header_cache / neigh_resolve_output
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied, thanks Eric.