netdev - Re: [PATCH net-next] net: add a READ_ONCE() in skb_peek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191107.200837.35212301710315857.davem@davemloft.net>
Date:   Thu, 07 Nov 2019 20:08:37 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net-next] net: add a READ_ONCE() in skb_peek_tail()

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu,  7 Nov 2019 18:49:43 -0800

> skb_peek_tail() can be used without protection of a lock,
> as spotted by KCSAN [1]
> 
> In order to avoid load-stearing, add a READ_ONCE()
> 
> Note that the corresponding WRITE_ONCE() are already there.
> 
> [1]
> BUG: KCSAN: data-race in sk_wait_data / skb_queue_tail
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Also applied.