netdev - Re: [PATCH iproute2-next 0/5] ipnetns: cleanup and harden processing of netns ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Nov 2019 18:36:31 -0700
From:   David Ahern <dsahern@...il.com>
To:     Guillaume Nault <gnault@...hat.com>
Cc:     netdev@...r.kernel.org, Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH iproute2-next 0/5] ipnetns: cleanup and harden processing
 of netns ids

On 11/8/19 10:00 AM, Guillaume Nault wrote:
> It's currently hard to review ipnetns. The netns ids are inconsistently
> treated as signed or unsigned and most helper functions aren't prepared
> to use negative ids.
> 
> Netns id attributes can be negative: NETNSA_NSID_NOT_ASSIGNED == -1.
> So let's consistently treat nsids as signed and also reject negative
> values in functions that are supposed to only handle assigned netns
> ids.
> 
> While there, let's drop the extra blank line generated by some command
> line parsing errors (patch 5/5).
> 
> Guillaume Nault (5):
>   ipnetns: treat NETNSA_NSID and NETNSA_CURRENT_NSID as signed
>   ipnetns: fix misleading comment about 'ip monitor nsid'
>   ipnetns: harden helper functions wrt. negative netns ids
>   ipnetns: don't print unassigned nsid in json export
>   ipnetns: remove blank lines printed by invarg() messages
> 
>  ip/ipnetns.c | 49 +++++++++++++++++++++++++++++--------------------
>  1 file changed, 29 insertions(+), 20 deletions(-)
> 

looks good. applied to iproute2-next. Thanks for doing the cleanup.