netdev - Re: [PATCH,bpf-next v2 2/2] samples: bpf: update map definition to new syntax BTF-defined map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJp9RyWX9d9DKMgvC-kaYQiPv0ae0DMHJx4KENechoYeA@mail.gmail.com>
Date:   Fri, 8 Nov 2019 19:26:24 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     "Daniel T. Lee" <danieltimlee@...il.com>
Cc:     Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH,bpf-next v2 2/2] samples: bpf: update map definition to
 new syntax BTF-defined map

On Wed, Nov 6, 2019 at 8:45 PM Daniel T. Lee <danieltimlee@...il.com> wrote:
>
> On Thu, Nov 7, 2019 at 11:53 AM Andrii Nakryiko
> <andrii.nakryiko@...il.com> wrote:
> >
> > On Wed, Nov 6, 2019 at 4:52 PM Daniel T. Lee <danieltimlee@...il.com> wrote:
> > >
> > > Since, the new syntax of BTF-defined map has been introduced,
> > > the syntax for using maps under samples directory are mixed up.
> > > For example, some are already using the new syntax, and some are using
> > > existing syntax by calling them as 'legacy'.
> > >
> > > As stated at commit abd29c931459 ("libbpf: allow specifying map
> > > definitions using BTF"), the BTF-defined map has more compatablility
> > > with extending supported map definition features.
> > >
> > > The commit doesn't replace all of the map to new BTF-defined map,
> > > because some of the samples still use bpf_load instead of libbpf, which
> > > can't properly create BTF-defined map.
> > >
> > > This will only updates the samples which uses libbpf API for loading bpf
> > > program. (ex. bpf_prog_load_xattr)
> > >
> > > Signed-off-by: Daniel T. Lee <danieltimlee@...il.com>

Applied. Thanks