netdev - Re: [PATCH net-next 08/17] net: sfp: control TX_DISABLE and phy only from main state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191110181410.GT25889@lunn.ch>
Date:   Sun, 10 Nov 2019 19:14:10 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 08/17] net: sfp: control TX_DISABLE and phy only
 from main state machine

On Sun, Nov 10, 2019 at 02:06:49PM +0000, Russell King wrote:
> We initialise TX_DISABLE when the sfp cage is probed, and then
> maintain its state in the main state machine.  However, the module
> state machine:
> - negates it when detecting a newly inserted module when it's already
>   guaranteed to be negated.
> - negates it when the module is removed, but the main state machine
>   will do this anyway.
> 
> Make TX_DISABLE entirely controlled by the main state machine.
> 
> The main state machine also probes the module for a PHY, and removes
> the PHY when the the module is removed.  Hence, removing the PHY in
> sfp_sm_module_remove() is also redundant, and is a left-over from
> when we tried to probe for the PHY from the module state machine.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew