netdev - Re: [PATCH net-next 10/17] net: sfp: eliminate mdelay() from PHY probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191110193719.GW25889@lunn.ch>
Date:   Sun, 10 Nov 2019 20:37:19 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 10/17] net: sfp: eliminate mdelay() from PHY
 probe

On Sun, Nov 10, 2019 at 02:06:59PM +0000, Russell King wrote:
> Rather than using mdelay() to wait before probing the PHY (which holds
> several locks, including the rtnl lock), add an extra wait state to
> the state machine to introduce the 50ms delay without holding any
> locks.

Hi Russell

Is this 50ms part of the standard? Or did you find that empirically?

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew