netdev - Re: [PATCH V3 net-next 6/7] net: bcmgenet: Add RGMII_RXID and RGMII

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <741ffd9e-2f38-5605-2c44-e6411bf5d8d8@gmail.com>
Date:   Sun, 10 Nov 2019 12:32:38 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Stefan Wahren <wahrenst@....net>,
        Matthias Brugger <matthias.bgg@...nel.org>,
        Matthias Brugger <mbrugger@...e.com>,
        "David S . Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Eric Anholt <eric@...olt.net>,
        Nicolas Saenz Julienne <nsaenzjulienne@...e.de>,
        Doug Berger <opendmb@...il.com>, netdev@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3 net-next 6/7] net: bcmgenet: Add RGMII_RXID and
 RGMII_ID support



On 11/9/2019 11:00 AM, Stefan Wahren wrote:
> This adds the missing support for the PHY modes RGMII_RXID and
> RGMII_ID. Based on the used register settings in the downstream tree
> the mode RGMII_RXID is necessary for the Raspberry Pi 4.
> 
> Signed-off-by: Stefan Wahren <wahrenst@....net>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  drivers/net/ethernet/broadcom/genet/bcmmii.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> index 8f7b2c0..9091e5b 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
> @@ -273,6 +273,16 @@ int bcmgenet_mii_config(struct net_device *dev, bool init)
>  		phy_name = "external RGMII (TX delay)";
>  		port_ctrl = PORT_MODE_EXT_GPHY;
>  		break;
> +
> +	case PHY_INTERFACE_MODE_RGMII_RXID:
> +		phy_name = "external RGMII (RX delay)";
> +		port_ctrl = PORT_MODE_EXT_GPHY;
> +		break;
> +
> +	case PHY_INTERFACE_MODE_RGMII_ID:
> +		phy_name = "external RGMII (RX/TX delay)";
> +		port_ctrl = PORT_MODE_EXT_GPHY;
> +		break;

Technically for this one we should probably make sure that we do set
id_mode_dis in order for the MAC not to add the delay and leave the PHY
to do it though I don't have such a configuration handy to
prove/disprove that is necessary.
-- 
Florian