netdev - Re: [PATCH net-next v2 04/10] devlink: Support subdev HW address get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191110081251.GA2185@nanopsycho>
Date:   Sun, 10 Nov 2019 09:12:51 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Parav Pandit <parav@...lanox.com>
Cc:     Yuval Avnery <yuvalav@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        "leon@...nel.org" <leon@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "shuah@...nel.org" <shuah@...nel.org>,
        Daniel Jurgens <danielj@...lanox.com>,
        "andrew.gospodarek@...adcom.com" <andrew.gospodarek@...adcom.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>
Subject: Re: [PATCH net-next v2 04/10] devlink: Support subdev HW address get

Sat, Nov 09, 2019 at 07:13:30PM CET, parav@...lanox.com wrote:
>
>
>> From: Yuval Avnery <yuvalav@...lanox.com>
>> > > From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org>
>> > > Avnery <yuvalav@...lanox.com>
>> > > Subject: [PATCH net-next v2 04/10] devlink: Support subdev HW
>> > > address get
>> > >
>> > > Allow privileged user to get the HW address of a subdev.
>> > >
>> > > Example:
>> > >
>> > > $ devlink subdev show pci/0000:03:00.0/1
>> > > pci/0000:03:00.0/1: flavour pcivf pf 0 vf 0 port_index 1 hw_addr
>> > > 00:23:35:af:35:34
>> > >
>> > > $ devlink subdev show pci/0000:03:00.0/1 -pj {
>> > >     "subdev": {
>> > >         "pci/0000:03:00.0/1": {
>> > >             "flavour": "pcivf",
>> > >             "pf": 0,
>> > >             "vf": 0,
>> > >             "port_index": 1,
>> > >             "hw_addr": "00:23:35:af:35:34"
>> > I prefer this to be 'address' to match to 'ip link set address LLADDR'.
>> > That will make it consistent with rest of the iproute2/ip tool.
>> > So that users don't have to remember one mor keyword for the 'address'.
>> I think hw_addr is more accurate, and consistency doesn't exist here anyway.
>> We already have "ip link set vf set mac"
>> Address is not specific enough and can also mean IP address, while hw_addr
>> covers both ETH and IB
>Ok.
>
>Jiri,
>Do you want to wait to conclude the SF discussion, as we are discussing subdev there in confused state currently?

I belive that subdev is parallel to the discussion about SFs.