netdev - Re: Regression in mvneta with XDP patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Nov 2019 16:05:53 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Ilias Apalodimas <ilias.apalodimas@...aro.org>
Cc:     brouer@...hat.com, lorenzo@...nel.org,
        netdev <netdev@...r.kernel.org>
Subject: Re: Regression in mvneta with XDP patches

On Mon, Nov 11, 2019 at 04:33:52PM +0200, Ilias Apalodimas wrote:
> Hi Andrew,
> 
> On Mon, Nov 11, 2019 at 02:46:15PM +0100, Andrew Lunn wrote:
> > Hi Lorenzo, Jesper, Ilias
> > 
> > I just found that the XDP patches to mvneta have caused a regression.
> > 
> > This one breaks networking:
> 
> Thaks for the report.
> Looking at the DTS i can see 'buffer-manager' in it. The changes we made were
> for the driver path software buffer manager. 
> Can you confirm which one your hardware uses?

Hi Ilias

Ah, interesting.

# CONFIG_MVNETA_BM_ENABLE is not set

So in fact it is not being compiled in, so should be falling back to
software buffer manager.

If i do enable it, then it works. So we are in a corner cases you
probably never tested. Requested by DT, but not actually available.

	 Andrew