netdev - Re: [PATCH 13/23] y2038: socket: remove timespec reference in timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2k-ZHAiCMBHWHvtwRfYqnz7aFGfqSYT8sLSyOf7Dm8Aw@mail.gmail.com>
Date:   Mon, 11 Nov 2019 21:24:51 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     y2038 Mailman List <y2038@...ts.linaro.org>,
        "David S. Miller" <davem@...emloft.net>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH 13/23] y2038: socket: remove timespec reference in timestamping

On Fri, Nov 8, 2019 at 10:15 PM Arnd Bergmann <arnd@...db.de> wrote:

> diff --git a/include/uapi/linux/errqueue.h b/include/uapi/linux/errqueue.h
> index 28491dac074b..0cca19670fd2 100644
> --- a/include/uapi/linux/errqueue.h
> +++ b/include/uapi/linux/errqueue.h
> @@ -37,9 +37,16 @@ struct sock_extended_err {
>   *     The timestamping interfaces SO_TIMESTAMPING, MSG_TSTAMP_*
>   *     communicate network timestamps by passing this struct in a cmsg with
>   *     recvmsg(). See Documentation/networking/timestamping.txt for details.
> + *     User space sees a timespec definition that matches either
> + *     __kernel_timespec or __kernel_old_timespec, in the kernel we
> + *     require two structure definitions to provide both.
>   */
>  struct scm_timestamping {
> +#ifdef __KERNEL__
> +       struct __kernel_old_timespec ts[3];
> +#else
>         struct timespec ts[3];
> +#endif
>  };

The kbuild bot pointed out that the way I sent this series, the use of
__kernel_old_timespec
causes a build failure, because I introduce this in a separate submission. I'm
moving this patch over to the other series, and changing the subject to

y2038: socket: use __kernel_old_timespec instead of timespec

With the expectation of merging it along with the other core patches.

      Arnd